Skip to content

reset flag can now also be str of spider name in addition to bool #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reset flag can now also be str of spider name in addition to bool #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scrapy_deltafetch/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,13 @@ def from_crawler(cls, crawler):
if not s.getbool('DELTAFETCH_ENABLED'):
raise NotConfigured
dir = data_path(s.get('DELTAFETCH_DIR', 'deltafetch'))
reset = s.getbool('DELTAFETCH_RESET')

# DELTAFETCH_RESET can be bool (for all spiders) or str of specific spider name
try:
reset = s.getbool('DELTAFETCH_RESET')
except ValueError:
reset = s.get('DELTAFETCH_RESET')

o = cls(dir, reset, crawler.stats)
crawler.signals.connect(o.spider_opened, signal=signals.spider_opened)
crawler.signals.connect(o.spider_closed, signal=signals.spider_closed)
Expand All @@ -49,7 +55,7 @@ def spider_opened(self, spider):
# TODO may be tricky, as there may be different paths on systems
dbpath = os.path.join(self.dir, '%s.db' % spider.name)
reset = self.reset or getattr(spider, 'deltafetch_reset', False)
flag = 'n' if reset else 'c'
flag = 'n' if reset is True or reset == spider.name else 'c'
try:
self.db = dbm.open(dbpath, flag=flag)
except Exception:
Expand Down