build: remove old Babel plugins #204
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These plugins are probably no longer necessary, and `@babel/preset-env` should add them if they are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the Babel plugins that we were using in
scratch-gui.Reason for Changes
It's (probably) safe because these plugins are probably no longer necessary with modern browsers and Babel 7, and
@babel/preset-envshould add them if needed.It's desirable because async call stacks are MUCH easier to read without these polyfills getting in the way, especially the
transform-async-to-generatorone.Test Coverage
Somewhat covered by existing tests but should be tested with more browsers. So far, I have only tested a relatively recent version of Chromium.