Feat: [UEPR-165] merge native into develop with platform #220
Conversation
Use the same implementation as onSetProjectThumbnailer which does the same thing for getting a thumbnail externally.
This reverts commit fa44d94.
Usually we generate a thumbnail when a project is changed. If a project is imported on Android it doesn’t have a thumbnail, and if you just run it without changes it still doesn’t have a thumbnail. Adding `saveThumbnailOnLoad` flag that Android sets if the project doesn’t have a thumbnail.
Generate a thumbnail for new projects and imported projects when loaded on android * use `isShowingWithId` instead of `isLoading`, loading finishes while project id is still `“0”` for new projects * use a timeout for storing the project thumbnail to ensure that it happens after target skins are rendered (they are rendered async)
| @@ -0,0 +1,219 @@ | |||
| name: CI/CD | |||
|
|
|||
There was a problem hiding this comment.
Is this used for anything? Can it be removed?
| @@ -196,6 +196,8 @@ describe('Working with costumes', () => { | |||
| await expect(logs).toEqual([]); | |||
| }); | |||
|
|
|||
| // Doesn't work on Android | |||
| /* | |||
| // TODO: This sometimes results in a stack overflow error in the GitHub Actions workflow - flaky test. | |||
| // Seems like at random another costume is shown. Need to debug | |||
| test.skip('Costumes animate on mouseover', async () => { | |||
There was a problem hiding this comment.
Let's either rewrite or delete this
| const loadSpanish = () => | ||
| import(/* webpackChunkName: "es-steps" */ './es-steps.js') | ||
| .then(({esImages: imageData}) => imageData); | ||
| // const loadSpanish = () => |
There was a problem hiding this comment.
Let's uncomment this. Where is it used? Does it result in missing files on android?
Bogomil-Stoyanov
force-pushed
the
feat/uepr-165-merge-native-into-develop-with-platform
branch
from
8f03083 to
bd723db
Compare
There was a problem hiding this comment.
Wow, I shouldn't have said that the Android PR was surprisingly simple... this one makes up for it! ;)
I had very little to add on top of Kalo's existing comments. Great work! I'm sure we'll be able to simplify things in the future, maybe merge some code paths, but getting the paths next to each other in the same branch is a huge step. Thank you!
| @@ -24,8 +24,23 @@ const PHASES = keyMirror({ | |||
| updatePeripheral: null | |||
| }); | |||
|
|
|||
| const ConnectionModalComponent = props => ( | |||
| <Modal | |||
| const ConnectionModalComponent = props => { | |||
There was a problem hiding this comment.
@MarshTheTester, we'll need to specifically check hardware extensions for the next Android release. We should include both new (CDM) and old (non-CDM) tablets.
| @@ -0,0 +1,146 @@ | |||
| import PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
Conflicts should be resolved in #226
|
Thinking of closing this and migrating further discussion to - #226 - mainly because some comments/issues here are addressed in that PR and it doesn't make sense for this to be merged on its own anymore. I could add a link for (some) backtracing. What do you think @cwillisf |
Ticket:
UEPR-165