Skip to content

Add RTL support to delete-confirmation-prompt in scratch-gui #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pishi-ai
Copy link

This commit adds RTL (Right-to-Left) language support to the delete-confirmation-prompt component in scratch-gui.

Resolves

In RTL languages, when multiple sprites are opened, the confirmation prompt extends beyond the window boundary. This PR fixes that issue by properly handling RTL layout.

Proposed Changes

  • Updated layout and styles to support RTL rendering for the delete-confirmation-prompt
  • Adjusted alignment logic and directional styling
  • Ensured icon and button positioning respects RTL direction
  • Modified 6 existing files
  • Added 1 new file

Reason for Changes

RTL language support is essential for accessibility and internationalization. Without proper handling, the confirmation prompt becomes unusable in RTL contexts. This update ensures consistent behavior and layout across both LTR and RTL languages.

Test Coverage

  • Manually tested the delete-confirmation-prompt in RTL and LTR languages
  • Verified the prompt displays fully within the window and aligns correctly
  • Confirmed no regression in LTR behavior

this commit adds rtl support to the delete-confirmation-prompt of scratch-gui.
@pishi-ai pishi-ai requested a review from a team as a code owner April 13, 2025 16:26
Copy link

github-actions bot commented Apr 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@pishi-ai
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@cwillisf cwillisf requested a review from KManolov3 April 14, 2025 14:52
@cwillisf
Copy link
Contributor

@pishi-ai, thanks for your help! I really appreciate the testing notes, too.

@cwillisf
Copy link
Contributor

@KManolov3, do you have time to review this? If not, let me know.
I took a quick look: it seems generally reasonable, but you're the expert here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants