Added border radius to "What's happening?" user icons. #9736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many places in the website where user icons have a border-radius property of 3 pixels, however the What's happening? section has fully squared borders that do not match the rest. It can be noticed with high zoom. Padding was replaced by margin because it prevented the border radius from working correctly and was redundant. Replacing it with margin does not affect anything and is in fact cleaner. Works for all devices and browsers.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
The "What's happening?" profile pictures of the users do not have a border radius, while the rest of the Scratch website shows profile pictures with a border-radius of 3 pixels.
Changes:
This pull request is a minor change that just adds the border-radius property of 3px to the icons so they match the same style of other places and also replaces the image padding by margin, because padding was redundant and only causing visual issues.
Test Coverage:
Tested on 4 browsers and 2 devices (a computer and a phone) - Works fine as expected: