fix(command-mode): fix shift key and capitalization behaviour#297
Conversation
Correct capitalization behavior, fix shift key icon, and handle German plural noun capitalization. Closes scribe-org#287
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks for this, @smalik2811! :) We'll get to the review soon 😊 |
| Log.i("MY-TAG", "PLURAL STATE") | ||
| updateKeyboardMode(true) | ||
| currentState = ScribeState.PLURAL | ||
| if (language == "German") { |
|
One thing to note here is that we should switch to the letter keys when the user selects a command, but we can work on this in another issue :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Is looking good to me, @smalik2811! Thanks for the great first contribution :) Let's look into the tests, and I'll make the issue for switch the keyboard to letters for commands now, so maybe you'd have interest in that as well 😊
Correct capitalization behavior, fix shift key icon, and handle German plural noun capitalization.
Closes #287
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request addresses issue #287 by resolving several issues with the command bar:
Related issue