Skip to content

fix(command-mode): fix shift key and capitalization behaviour#297

Merged
andrewtavis merged 2 commits intoscribe-org:mainfrom
smalik2811:fix-287-shift-key-behavior-in-command-mode
Jan 16, 2025
Merged

fix(command-mode): fix shift key and capitalization behaviour#297
andrewtavis merged 2 commits intoscribe-org:mainfrom
smalik2811:fix-287-shift-key-behavior-in-command-mode

Conversation

@smalik2811
Copy link
Contributor

Correct capitalization behavior, fix shift key icon, and handle German plural noun capitalization.

Closes #287

Contributor checklist


Description

This pull request addresses issue #287 by resolving several issues with the command bar:

  • Corrected text capitalization behavior: Ensured correct capitalization of text entered in the command bar, including proper handling of cases like German plural nouns.
  • Fixed shift key icon behavior: Corrected an issue where the shift key icon and label of the keys did not accurately reflect the shift key state during command mode.

Related issue

Correct capitalization behavior, fix shift key icon, and handle German plural noun capitalization.

Closes scribe-org#287
@github-actions
Copy link

github-actions bot commented Jan 16, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis
Copy link
Member

Thanks for this, @smalik2811! :) We'll get to the review soon 😊

Log.i("MY-TAG", "PLURAL STATE")
updateKeyboardMode(true)
currentState = ScribeState.PLURAL
if (language == "German") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for this, @smalik2811!

@andrewtavis
Copy link
Member

One thing to note here is that we should switch to the letter keys when the user selects a command, but we can work on this in another issue :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is looking good to me, @smalik2811! Thanks for the great first contribution :) Let's look into the tests, and I'll make the issue for switch the keyboard to letters for commands now, so maybe you'd have interest in that as well 😊

@andrewtavis andrewtavis merged commit 6e577f4 into scribe-org:main Jan 16, 2025
4 checks passed
@smalik2811 smalik2811 deleted the fix-287-shift-key-behavior-in-command-mode branch January 16, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text entry is being capitalized for Scribe command bar

2 participants