Fix initial state (on app install) of dark mode toggle.#304
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
@angrezichatterbox, would you be able to take a look at this? Maybe @mnzoidi as well? :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
The changes look great to me, @janiceferns02. Thanks for resolving the issue. I hope we can see you resolve more issues for Scribe. I think it’s a good for merge @andrewtavis
|
Thanks for the review, @angrezichatterbox! And thanks also for the continued great work in the community, @janiceferns02! 😊 |
|
Thanks! It feels great to see the issue is resolved and the PR merged. :-) |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Correct the initial state of the dark mode toggle button to match the device's system dark mode preference on first launch.
Tested on device with both dark mode and light mode enabled in system settings and verified that the dark mode toggle button now correctly matches the system preference on app launch.
Also tested that the toggle button updates when the user changes the dark mode setting within the app.
Related issue