Skip to content

Added translation source language option to language setting screen#330

Merged
andrewtavis merged 5 commits intoscribe-org:mainfrom
ThousandYearGrind:main
Mar 9, 2025
Merged

Added translation source language option to language setting screen#330
andrewtavis merged 5 commits intoscribe-org:mainfrom
ThousandYearGrind:main

Conversation

@ThousandYearGrind
Copy link
Contributor

Contributor checklist


Description

Added translation source language option to language settings screen
The actual selection does not work (just a clickable ui item)

I ran my code in Android Studio and saw the option in Settings > Select Installed Keyboard > English
I also ran the ./gradlew lintKotlin detekt test to check my code

Related issue

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@angrezichatterbox
Copy link
Member

Hey @ThousandYearGrind.

The issue actually wants you to show the different languages on clicking the select language menu option and then select the specific language and store it in shared preferences that could be accessed later on for different languages differently.

Would you like to do that in the same PR

@ThousandYearGrind
Copy link
Contributor Author

Hi @angrezichatterbox
I tried to do that initially but did not know how to open up a separate menu for language selection. Maybe I can come back to it after I learn more, but for now it would probably be better to open it up so other people who do know how to do it could work on it.

@angrezichatterbox
Copy link
Member

Should I make changes within the same PR for adding the individual languages or a menu or should a separate issue be made for it @andrewtavis

@andrewtavis
Copy link
Member

I think we'd be good to make changes within this PR and resolve the issue, @angrezichatterbox :) Thanks for checking!

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Mar 4, 2025

Should The translation selection be a separate page or should an overlay with the options be present or just a drop down for the languages.

@andrewtavis
Copy link
Member

I think the plan was a separate page so it's a bit consistent with going to sub menu pages, but then I haven't actually thought of other options 🤔 I think a popover would be better than a dropdown. See the designs here. If we want to switch to a popover, then we should think of a different interaction icon for these options than >, as that indicates that we're going to a sub-page.

Any thoughts on this, @angrezichatterbox? :)

@angrezichatterbox
Copy link
Member

I think the plan was a separate page so it's a bit consistent with going to sub menu pages, but then I haven't actually thought of other options 🤔 I think a popover would be better than a dropdown. See the designs here. If we want to switch to a popover, then we should think of a different interaction icon for these options than >, as that indicates that we're going to a sub-page.

Any thoughts on this, @angrezichatterbox? :)

I think subpages would be good if we would have a lot of language at any point and the consistency would be maintained across the app.

@andrewtavis
Copy link
Member

Good point that scrolling a popover would be really annoying 😊 Let's stick with sub pages as is in the designs then!

@angrezichatterbox
Copy link
Member

It is ready for review :)

@angrezichatterbox angrezichatterbox force-pushed the main branch 2 times, most recently from cda2d38 to 83698b3 Compare March 9, 2025 12:22
@andrewtavis
Copy link
Member

Nice @angrezichatterbox! I'll get to this later today :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's functioning really well, @angrezichatterbox! And thanks for the great start here, @ThousandYearGrind 😊 Glad to have the menu for keyboards so well set up 🥳

@andrewtavis andrewtavis merged commit 3357095 into scribe-org:main Mar 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants