Added translation source language option to language setting screen#330
Added translation source language option to language setting screen#330andrewtavis merged 5 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Hey @ThousandYearGrind. The issue actually wants you to show the different languages on clicking the select language menu option and then select the specific language and store it in shared preferences that could be accessed later on for different languages differently. Would you like to do that in the same PR |
|
Hi @angrezichatterbox |
|
Should I make changes within the same PR for adding the individual languages or a menu or should a separate issue be made for it @andrewtavis |
|
I think we'd be good to make changes within this PR and resolve the issue, @angrezichatterbox :) Thanks for checking! |
|
Should The translation selection be a separate page or should an overlay with the options be present or just a drop down for the languages. |
|
I think the plan was a separate page so it's a bit consistent with going to sub menu pages, but then I haven't actually thought of other options 🤔 I think a popover would be better than a dropdown. See the designs here. If we want to switch to a popover, then we should think of a different interaction icon for these options than Any thoughts on this, @angrezichatterbox? :) |
I think subpages would be good if we would have a lot of language at any point and the consistency would be maintained across the app. |
|
Good point that scrolling a popover would be really annoying 😊 Let's stick with sub pages as is in the designs then! |
|
It is ready for review :) |
cda2d38 to
83698b3
Compare
|
Nice @angrezichatterbox! I'll get to this later today :) |
andrewtavis
left a comment
There was a problem hiding this comment.
All's functioning really well, @angrezichatterbox! And thanks for the great start here, @ThousandYearGrind 😊 Glad to have the menu for keyboards so well set up 🥳
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Added translation source language option to language settings screen
The actual selection does not work (just a clickable ui item)
I ran my code in Android Studio and saw the option in Settings > Select Installed Keyboard > English
I also ran the ./gradlew lintKotlin detekt test to check my code
Related issue