improved emoji handleing

[bhanu-dev82]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

• #ISSUE_NUMBER : Have emoji autocompletion replace the word if there is no space #313
• updated the existing function to handle cases without spaces at the end.
• included comments for documentation.

[github-actions]

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Thanks for the PR, @bhanu-dev82! We'll get to the review in the coming days :)

[andrewtavis]

One thing here @bhanu-dev82 is that this might not hold always. Maybe we can load this in from the DB for the emojis table? Let me know what you think here :)

[bhanu-dev82]

yes i will implement it and commit

[andrewtavis]

Aside from the comment above all's looking and working great, @bhanu-dev82! Let us know what you think about getting that value from the DB and we can go from there :)

[andrewtavis]

We can also make an issue for that as well, if you'd prefer 😊

[angrezichatterbox]

I only felt one thing within the emoji replacement. It felt a little laggy. Maybe this is my personal issue as I am on an emulator. If not we could have an issue to look into this as well.
We could look into batch edit within the IME feature for optimizing this a bit probably.

[andrewtavis]

Ya maybe a separate issue for that would be good :) Do you want to make an issue, @angrezichatterbox? Please let us know if you'd like to do the work of figuring out the max keyword length via the database in this PR, @bhanu-dev82!

[angrezichatterbox]

Ya maybe a separate issue for that would be good :) Do you want to make an issue, @angrezichatterbox?

I would create an issue for it once this is merged in :)

[bhanu-dev82]

I only felt one thing within the emoji replacement. It felt a little laggy. Maybe this is my personal issue as I am on an emulator. If not we could have an issue to look into this as well. We could look into batch edit within the IME feature for optimizing this a bit probably.

yes we can improve the performance, i will update and commit

[bhanu-dev82]

Ya maybe a separate issue for that would be good :) Do you want to make an issue, @angrezichatterbox? Please let us know if you'd like to do the work of figuring out the max keyword length via the database in this PR, @bhanu-dev82!

i will figure out the make keyword length from database

[bhanu-dev82]

I have updated the code with batch editing and database integration for maxlen. kindly provide feedback

[andrewtavis]

Wonderful work, @bhanu-dev82! I'll let @angrezichatterbox confirm given his comment on the performance. Looking forward to bringing this in! 🚀

[angrezichatterbox]

Wonderful work, @bhanu-dev82! I'll let @angrezichatterbox confirm given his comment on the performance. Looking forward to bringing this in! 🚀

I will look into this PR and the other one tmrw. There was a little mess-up in my android studio configuration. I am currently trying to fix it.

[angrezichatterbox]

It looks fine to me. Something interesting is that the emoji insertion is slow if the first word is an emoji otherwise it is handled fine. We could look into this as another issue I think.
I think the code can be simplified a bit. Instead of having separate cases. The line could be split by space and emoji suggestion could be replaced for the last word. Instead of having a when case.

[andrewtavis]

Assuming it's fine to send along 88d62b0 as we're not using MAX_EMOJI_KEYWORD_LENGTH :)

[andrewtavis]

Amazing work, @bhanu-dev82, and thanks for the support and review, @angrezichatterbox! 😊 Hope we can work with you again soon on another issue, @bhanu-dev82!