Fix command keys color mismatch with Scribe key in dark mode.#333
Fix command keys color mismatch with Scribe key in dark mode.#333janiceferns02 wants to merge 2 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Thanks for the PR @janiceferns02. For the command mode input the color seems to be same as before. Could that be fixed. After that we would be good :)
|
@angrezichatterbox Sure, I’ve fixed the command mode color now. The command bar hint text, prompt text, and input text are in black - do you need any changes there? |
|
The text within the mode has to be in white. But that doesn't come within this issue scope. Could you also revert back the color of the keyboard to what was initially present. After that you could push your changes so that I could review it properly. |
|
@angrezichatterbox The branch was not updated with the latest code and it also has conflicts 😬, so I have raised another PR. Request you to review that one instead. Thanks! |
|
Closing this PR as a new one has been raised: #334 |
|
Thanks for closing given the new PR, @janiceferns02 :) |

Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Fix command key colour inconsistency with Scribe key in dark mode. Now command keys colour matches with the scribe key in both light and dark mode. Tested by switching the dark mode in app. Also tested by switching the device's theme on Samsung A34 5G.
Related issue