Skip to content

Fix command keys color mismatch with Scribe key in dark mode.#333

Closed
janiceferns02 wants to merge 2 commits intoscribe-org:mainfrom
janiceferns02:bugfix/dark_mode_coloration_of_command_bar
Closed

Fix command keys color mismatch with Scribe key in dark mode.#333
janiceferns02 wants to merge 2 commits intoscribe-org:mainfrom
janiceferns02:bugfix/dark_mode_coloration_of_command_bar

Conversation

@janiceferns02
Copy link
Contributor

Contributor checklist


Description

Fix command key colour inconsistency with Scribe key in dark mode. Now command keys colour matches with the scribe key in both light and dark mode. Tested by switching the dark mode in app. Also tested by switching the device's theme on Samsung A34 5G.

Related issue

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @janiceferns02. For the command mode input the color seems to be same as before. Could that be fixed. After that we would be good :)

@janiceferns02
Copy link
Contributor Author

janiceferns02 commented Mar 15, 2025

commandbarcoloration_sc

@angrezichatterbox Sure, I’ve fixed the command mode color now. The command bar hint text, prompt text, and input text are in black - do you need any changes there?

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Mar 15, 2025

The text within the mode has to be in white. But that doesn't come within this issue scope. Could you also revert back the color of the keyboard to what was initially present. After that you could push your changes so that I could review it properly.

@janiceferns02
Copy link
Contributor Author

janiceferns02 commented Mar 15, 2025

@angrezichatterbox The branch was not updated with the latest code and it also has conflicts 😬, so I have raised another PR. Request you to review that one instead. Thanks!

View PR

@janiceferns02
Copy link
Contributor Author

Closing this PR as a new one has been raised: #334

@andrewtavis
Copy link
Member

Thanks for closing given the new PR, @janiceferns02 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants