Skip to content

App hints tooltips#335

Merged
andrewtavis merged 5 commits intoscribe-org:mainfrom
catreedle:app_hints_tooltips
Mar 17, 2025
Merged

App hints tooltips#335
andrewtavis merged 5 commits intoscribe-org:mainfrom
catreedle:app_hints_tooltips

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

This pull request is to improve styling of app hints tooltips as described in issue #323
I have:

  • changed the button color
  • add shadow to button and tooltips
  • added horizontal padding
  • placed the tooltips slightly lower
  • increased font size of OK

Related issue

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@catreedle
Copy link
Collaborator Author

catreedle commented Mar 17, 2025

Installation

ss1

Settings

ss2

About

ss3

@andrewtavis
Copy link
Member

andrewtavis commented Mar 17, 2025

ccacaaa are the changes that immediately jumped out to me, @catreedle :) Could we ask you to reduce the shadow length on the OK button to around what I set it for the tooltip, and then we should be good to go! 😊

@catreedle
Copy link
Collaborator Author

hi @andrewtavis, using the previous method I can't really customize the shadow button.
I changed it to using drawBehind I think it's more customizable now. Please let me know what you think.

ss4

@andrewtavis
Copy link
Member

Amazing, @catreedle! I'll bring this in later :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work for another great contribution to Scribe-Android, @catreedle! Very happy to have you contributing again 😊 Hope to see you at the next sync this Saturday!

@andrewtavis andrewtavis merged commit dc20f66 into scribe-org:main Mar 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants