Improve the styling of quick tutorial and install keyboard buttons#336
Improve the styling of quick tutorial and install keyboard buttons#336andrewtavis merged 2 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
| horizontal = 12.dp, | ||
| vertical = 10.dp, | ||
| ).clip(RoundedCornerShape(12.dp)) | ||
| ).clip(RoundedCornerShape(8.dp)) |
There was a problem hiding this comment.
This reduces the shape of the rounded corner making the description show fully. The previous padding of 12 clips the description.
| Modifier | ||
| .width(51.dp) | ||
| .height(31.dp), | ||
| .height(17.dp), |
There was a problem hiding this comment.
Setting the height of the icon to 31 shifts the description of the card a little lower than that of Clickable Item card, making the view inconsistent.
Reducing the height fixes this.
| .fillMaxWidth() | ||
| .padding(vertical = Dimensions.PaddingLarge), | ||
| .padding(vertical = Dimensions.PaddingLarge) | ||
| .shadow(Dimensions.ElevationSmall, RoundedCornerShape(Dimensions.PaddingLarge)), |
There was a problem hiding this comment.
Added shadow to the button
|
Thanks for the PR, @Femimat! We'll get to the review soon. Looks ready to me :) |
andrewtavis
left a comment
andrewtavis
left a comment
There was a problem hiding this comment.
Really great work here, @Femimat! Hope to work with you on another issue soon! Please let us know if another one would be of interest to you 😊
|
Change on my end was just a minor reduction of the text size :) |
Sure, I will. Thanks, @andrewtavis! |
2 participants
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This fix improves the styling of quick tutorial and install keyboard buttons. These button have been styled to look more like the design graphic shown in the linked issue.
Screenshots
Related issue