Fix Caps Lock Icon Theming and Improve Shift Key Behavior#338
Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom Mar 19, 2025
Merged
Conversation
…lor also fixed caps_lock key to respect theme
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
andrewtavis
approved these changes
Mar 19, 2025
Member
andrewtavis
left a comment
There was a problem hiding this comment.
Really well done, @bhanu-dev82 :) Really is great to have you in the community! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR addresses theming issues with the keyboard icons and improves the visual feedback for shift key states. The main improvements include:
These changes improve the overall user experience by providing consistent visual feedback across the keyboard interface and ensuring proper theme compliance for all UI elements.
Related issue
Technical details
onBufferDraw()methodTesting
Tested on multiple devices in both light and dark modes to ensure proper theming across all conditions.