Skip to content

Fix Caps Lock Icon Theming and Improve Shift Key Behavior#338

Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom
bhanu-dev82:fixed-colour-of-shift-locked-state
Mar 19, 2025
Merged

Fix Caps Lock Icon Theming and Improve Shift Key Behavior#338
andrewtavis merged 1 commit intoscribe-org:mainfrom
bhanu-dev82:fixed-colour-of-shift-locked-state

Conversation

@bhanu-dev82
Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

This PR addresses theming issues with the keyboard icons and improves the visual feedback for shift key states. The main improvements include:

  1. Fixed the caps lock icon to properly respect the system/user theme in both light and dark modes
  2. Applied consistent color filtering to all special keys including caps lock
  3. Improved the visual consistency between caps lock on/off states by aligning their dimensions
  4. Enhanced the shift key behavior to provide clear visual feedback when locked

These changes improve the overall user experience by providing consistent visual feedback across the keyboard interface and ensuring proper theme compliance for all UI elements.

Related issue

Technical details

  • Applied color filtering to caps lock icons in the onBufferDraw() method
  • Updated drawable XML files to use theme-aware color resources
  • Aligned dimensions between caps lock on/off states for visual consistency
  • Implemented proper visual feedback for shift locked state using the key pressed color

Testing

Tested on multiple devices in both light and dark modes to ensure proper theming across all conditions.

…lor also fixed caps_lock key to respect theme
@github-actions
Copy link
Copy Markdown

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review March 19, 2025 15:10
Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well done, @bhanu-dev82 :) Really is great to have you in the community! 🚀

@andrewtavis andrewtavis merged commit 38ea11c into scribe-org:main Mar 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shift key on keyboard should be a slightly different color when activated

2 participants