Skip to content

Implement Conjugate view for English#511

Merged
andrewtavis merged 13 commits intoscribe-org:mainfrom
angrezichatterbox:Implement-the-conjugate-for-english
Nov 23, 2025
Merged

Implement Conjugate view for English#511
andrewtavis merged 13 commits intoscribe-org:mainfrom
angrezichatterbox:Implement-the-conjugate-for-english

Conversation

@angrezichatterbox
Copy link
Member

Contributor checklist


Description

This PR implements the conjugate view for English and subsequent views when there are further things.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox angrezichatterbox force-pushed the Implement-the-conjugate-for-english branch 3 times, most recently from f2b7e99 to c2e0d1d Compare November 22, 2025 12:50
@andrewtavis andrewtavis self-requested a review November 22, 2025 12:51
@andrewtavis
Copy link
Member

Amazing to have this in, @angrezichatterbox! Let's find some time for a review whenever you have time 😊

@angrezichatterbox angrezichatterbox force-pushed the Implement-the-conjugate-for-english branch from c2e0d1d to 1eecc12 Compare November 22, 2025 12:56
@angrezichatterbox
Copy link
Member Author

Amazing to have this in, @angrezichatterbox! Let's find some time for a review whenever you have time 😊

I will be free tonight. I am a little busy throughout this upcoming week.

@andrewtavis
Copy link
Member

I'll check in with you for a time for the call on Matrix, @angrezichatterbox :)

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2025

Checking this with @angrezichatterbox now - things that we'll fix:

  • Conjugate view keyboard background color
  • Conjugate view key color
  • Removing the shadow from alternate/accent keys to close Improve non-hold key callouts #21
  • When the user clicks the Scribe key when it's an X within a conjugation selection view it goes back to the view to type a new verb (conjugate state) rather than into the idle state :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Soooo amazing to have this finished, @angrezichatterbox 😊😊 We're officially down to #499, inspecting potential issues and generating the new data for the keyboards :) Looking forward to bringing Scribe-Android through the finish line!

@andrewtavis andrewtavis merged commit acbb7f4 into scribe-org:main Nov 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants