Implement Conjugate view for English#511
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
f2b7e99 to
c2e0d1d
Compare
|
Amazing to have this in, @angrezichatterbox! Let's find some time for a review whenever you have time 😊 |
c2e0d1d to
1eecc12
Compare
I will be free tonight. I am a little busy throughout this upcoming week. |
|
I'll check in with you for a time for the call on Matrix, @angrezichatterbox :) |
|
Checking this with @angrezichatterbox now - things that we'll fix:
|
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Soooo amazing to have this finished, @angrezichatterbox 😊😊 We're officially down to #499, inspecting potential issues and generating the new data for the keyboards :) Looking forward to bringing Scribe-Android through the finish line!
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR implements the conjugate view for English and subsequent views when there are further things.
Related issue