add Update state to Download language button #513#514
add Update state to Download language button #513#514andrewtavis merged 2 commits intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
| @@ -93,6 +100,7 @@ private fun DownloadButtonContent( | |||
| DownloadState.Ready -> "Download" | |||
There was a problem hiding this comment.
We'll need to have localized versions of these words :) Do you want to make in issue for this in Scribe-i18n, @catreedle?
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Just checked this and all's working really really well, @catreedle! So great to see a version of the new UI and to have your great idea in the app already! 😊
|
created the localization issue here @andrewtavis :) scribe-org/Scribe-i18n#97 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This adds an Update state to the Download Language button in
DownloadDataOptionComp.The Update state is shown when the server language data differs from the local language data,
determined by comparing their respective last-updated dates.
This change currently uses placeholder dates to validate the state logic and UI behavior.
Related issue
Update data#513