Skip to content

add Update state to Download language button #513#514

Merged
andrewtavis merged 2 commits intoscribe-org:mainfrom
catreedle:update-state
Dec 10, 2025
Merged

add Update state to Download language button #513#514
andrewtavis merged 2 commits intoscribe-org:mainfrom
catreedle:update-state

Conversation

@catreedle
Copy link
Collaborator

@catreedle catreedle commented Dec 9, 2025

Contributor checklist


Description

This adds an Update state to the Download Language button in DownloadDataOptionComp.
The Update state is shown when the server language data differs from the local language data,
determined by comparing their respective last-updated dates.

This change currently uses placeholder dates to validate the state logic and UI behavior.

Related issue

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -93,6 +100,7 @@ private fun DownloadButtonContent(
DownloadState.Ready -> "Download"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to have localized versions of these words :) Do you want to make in issue for this in Scribe-i18n, @catreedle?

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Just checked this and all's working really really well, @catreedle! So great to see a version of the new UI and to have your great idea in the app already! 😊

@andrewtavis andrewtavis merged commit cef7468 into scribe-org:main Dec 10, 2025
6 checks passed
@catreedle
Copy link
Collaborator Author

created the localization issue here @andrewtavis :) scribe-org/Scribe-i18n#97
do I need to prioritize working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand download button options to include Update data

2 participants