Skip to content

Use shared corner radius across components#522

Merged
andrewtavis merged 2 commits intoscribe-org:mainfrom
Initye:unify-corner-radius
Dec 23, 2025
Merged

Use shared corner radius across components#522
andrewtavis merged 2 commits intoscribe-org:mainfrom
Initye:unify-corner-radius

Conversation

@Initye
Copy link
Contributor

@Initye Initye commented Dec 22, 2025

Contributor checklist


Description

Centralized the corner radius into a single shared dimen 'R.dimen.corner_radius_standard' and updated all components to reference it. I decided to create it inside dimens.xml because project currently has separate Dimensions objects in each file. This centralizes the corner radius and ensures consistency across components.

  • Updated 'Card' shapes and shadows to use the same corner radius,

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking really great, @Initye! Thanks so much for such a high quality first contribution! Hope we can work with you more in the future. Please let us know if you see an issue that would be of interest! 😊

@andrewtavis andrewtavis merged commit f8bbccc into scribe-org:main Dec 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make corner radius consistent throughout app pages (instalation should be more square)

2 participants