Use shared corner radius across components#522
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking really great, @Initye! Thanks so much for such a high quality first contribution! Hope we can work with you more in the future. Please let us know if you see an issue that would be of interest! 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Centralized the corner radius into a single shared dimen 'R.dimen.corner_radius_standard' and updated all components to reference it. I decided to create it inside dimens.xml because project currently has separate Dimensions objects in each file. This centralizes the corner radius and ensures consistency across components.
Related issue