Refactor: Extract backspace logic to dedicated handler (#480)#538
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
angrezichatterbox
left a comment
There was a problem hiding this comment.
Thanks for the PR @bhanu-dev82
Everything looks good to me. Great work
|
@andrewtavis I will merge this in :) |
|
Thanks for the great contribution, @bhanu-dev82, and thanks for the review and merge, @angrezichatterbox! 🚀💙 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR addresses issue #480 by extracting the complex backspace and deletion logic from GeneralKeyboardIME into a dedicated BackspaceHandler class
Changes:
Benefits:
Testing:
Related issue
Closes #480