Skip to content

tutorial working across languages#618

Open
ashb155 wants to merge 2 commits into
scribe-org:mainfrom
ashb155:reactivetutorial
Open

tutorial working across languages#618
ashb155 wants to merge 2 commits into
scribe-org:mainfrom
ashb155:reactivetutorial

Conversation

@ashb155

@ashb155 ashb155 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Contributor checklist


Description

This PR updates the quick tutorial to dynamically adapt its prompts, hints, and expected inputs based on the user's active Scribe keyboard language, resolving the issue of users being forced to use the German layout.

Key Changes:

  • Dynamic Content: Refactored TutorialContent.kt to supply localized words ("Mother"/"Father", gender tags) and hints for all 8 supported languages.
  • Reactive UI: Added a BroadcastReceiver in TutorialNavigator.kt to instantly update the tutorial text if the user switches keyboards mid-tutorial.

Related issue

Closes #616

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@ashb155 ashb155 changed the title Tutorial working across languages tutorial working across languages Jun 13, 2026
@andrewtavis

Copy link
Copy Markdown
Member

Hey @ashb155! A couple of comments on this from playing around with it :)

  • Let's do "mother" before "father"
  • For noun annotation, we should direct the user to also press space after typing the word in the directions
  • It's be great if we also accept capitalized versions of the words, so "Padre" as well as "padre" for Spanish
  • Ideally the "Next" button would also move up above the keyboard when it's active so that the user can directly press it
    • As of now the user needs to type the word, press enter and then they can see the "Next" button
  • We don't need the "If your second language is not..." message anymore as the tutorial is multilingual ✨
  • Can we change the 🌐 emoji to the similar icon? I think that'd look a bit more professional.
  • Let's get rid of the right arrow before "Scribe key" in the directions
    • Should we do something like "Press the Scribe key that looks like a pencil at the top left corner of your keyboard. Then select {keyboard option}"
  • It looks like we also need to localize the command key names in the messages to the user
    • We have "Übersetzen", "Konjugieren" and "Plural" in messages to the user, even if they're Spanish

@andrewtavis andrewtavis self-requested a review June 23, 2026 17:50
@andrewtavis

Copy link
Copy Markdown
Member

Would you also want to look into opening a PR in Scribe-i18n with the strings that are needed for the tutorial?

CC @prince-0408 and @angrezichatterbox for discussions about Scribe-i18n for Scribe-Android - let's continue to make sure that we have all the strings in that are needed for the apps in Scribe-i18n 👋

@ashb155

ashb155 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

hi @andrewtavis, thanks for your review and detailed comments, will have a look and work on them

also with regards to the PR for Scribe-i18n, sounds good, how about I hardcode the required strings as of now (as done in the PR), and later on once finalized we could maybe have a PR for i18n

@andrewtavis

Copy link
Copy Markdown
Member

Hard coding now and then migrating them to Scribe-i18n and then updating Scribe-i18n within the Android app is the exact thing we'd do, @ashb155 😊 Thanks so much! Looking forward to further commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow quick tutorial to work across languages

2 participants