Skip to content

Fix: bind tower proof's out evals to transcript - #1262

Merged
kunxian-xia merged 5 commits into
masterfrom
fix/bind_tower_evals
Mar 10, 2026
Merged

Fix: bind tower proof's out evals to transcript#1262
kunxian-xia merged 5 commits into
masterfrom
fix/bind_tower_evals

Conversation

@kunxian-xia

@kunxian-xia kunxian-xia commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #1125.

Performance (recursion prover)

The recursion proving time (for block 23817600):

  • before: 62s
  • after: 61.6s
shard total cells (baseline) total cells increase ratio
leaf 0 750,783,978 961,285,610 +28.04% (have no clue on this)
leaf 1 731,876,842 733,220,330 +0.18%
leaf 2 731,876,842 733,220,330 +0.18%
leaf 3 731,876,842 733,220,330 +0.18%
leaf 4 731,876,842 733,220,330 +0.18%
leaf 5 729,124,330 729,124,330 +0.00%
leaf 6 1,325,207,018 1,325,207,018 +0.00%
leaf 7 1,299,647,978 1,299,647,978 +0.00%
leaf 8 1,299,647,978 1,299,647,978 +0.00%
leaf 9 1,299,647,978 1,299,647,978 +0.00%
leaf 10 1,299,647,978 1,299,647,978 +0.00%
leaf 11 733,220,330 733,220,330 +0.00%
leaf 12 731,876,842 733,220,330 +0.18%
leaf 13 731,876,842 733,220,330 +0.18%
leaf 14 729,124,330 731,287,018 +0.30%

@kunxian-xia
kunxian-xia enabled auto-merge March 5, 2026 14:46
@kunxian-xia
kunxian-xia requested a review from hero78119 March 6, 2026 01:45

@hero78119 hero78119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I disable auto-merge as we are going to run ceno-reth regression test on this branch

@kunxian-xia
kunxian-xia added this pull request to the merge queue Mar 6, 2026
@hero78119
hero78119 removed this pull request from the merge queue due to a manual request Mar 6, 2026
@kunxian-xia

kunxian-xia commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Have this PR benchmarked at ceno-reth-benchmark.

@kunxian-xia
kunxian-xia added this pull request to the merge queue Mar 10, 2026
Merged via the queue into master with commit 8a63ff4 Mar 10, 2026
5 checks passed
@kunxian-xia
kunxian-xia deleted the fix/bind_tower_evals branch March 10, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing add r_out_evals / w_out_evals into transcript

2 participants