Feat/ Private input (fixed variant) #625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Follow-up to #620_ Simplify the `Platform` type by exposing the `Range` type. Co-authored-by: Aurélien Nicolas <[email protected]>
|
👍 will review #622 and see whats going on for the integration test error |
| @@ -22,7 +22,7 @@ pub const CENO_PLATFORM: Platform = Platform { | |||
| rom: 0x2000_0000..0x3000_0000, | |||
| ram: 0x8000_0000..0xFFFF_0000, | |||
| public_io: 0x3000_1000..0x3000_2000, | |||
| private_io: 0x4000_0000..0x5000_0000, | |||
| private_io: 0x4000_0000..0x4000_1000, | |||
There was a problem hiding this comment.
Interesting. Why the smaller range?
As mentioned on the other PR: please leave the end of the range fixed (if possible) and vary the start, if you have to.
There was a problem hiding this comment.
So it doesn’t take forever as this variant has a cost proportional to the fixed size.
| RowMajorMatrix::<F>::new(final_mem.len().next_power_of_two(), num_witness); | ||
| let max_len = DVRAM::max_len(&self.params); | ||
| assert!(final_mem.len() <= max_len); | ||
| assert!(max_len.is_power_of_two()); |
There was a problem hiding this comment.
0 should also be fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working but unsound variant of #622.
Example test command:
TODO:
DynamicAddrrecord evaluate != expected_evals.SetTableAddrType#573