Skip to content

refactor sumcheck boilerplate code by fix_var #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2025
Merged

refactor sumcheck boilerplate code by fix_var #868

merged 4 commits into from
Mar 20, 2025

Conversation

hero78119
Copy link
Collaborator

in preparation of #867

@hero78119 hero78119 force-pushed the feat/refactor_sumcheck branch from c38b57c to af5d729 Compare March 20, 2025 03:36
@hero78119 hero78119 force-pushed the feat/refactor_sumcheck branch from af5d729 to 387d231 Compare March 20, 2025 03:41
@hero78119 hero78119 requested a review from spherel March 20, 2025 03:46
@hero78119
Copy link
Collaborator Author

benchmark result no impact

fibonacci_max_steps_1048576/prove_fibonacci/fibonacci_max_steps_1048576
                        time:   [3.8944 s 3.9107 s 3.9307 s]
                        change: [-1.4155% -0.7170% +0.0225%] (p = 0.08 > 0.05)
                        No change in performance detected.

@hero78119 hero78119 enabled auto-merge March 20, 2025 03:50
spherel
spherel approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@spherel spherel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into scroll-tech:master with commit 057a016 Mar 20, 2025
4 checks passed
@hero78119 hero78119 deleted the feat/refactor_sumcheck branch March 20, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spherel spherel spherel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hero78119 @spherel