-
Notifications
You must be signed in to change notification settings - Fork 39
keccakf precompile + GKR-IOP integration
#893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
spherel
merged 18 commits into
scroll-tech:tianyi/refactor-prover
from
Inversed-Tech:mihai/keccakf_integration
May 2, 2025
Merged
keccakf precompile + GKR-IOP integration
#893
spherel
merged 18 commits into
scroll-tech:tianyi/refactor-prover
from
Inversed-Tech:mihai/keccakf_integration
May 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77c289e to
fce4a2c
Compare
fce4a2c to
7611e70
Compare
spherel
reviewed
Apr 3, 2025
26d44d6 to
1cedbc8
Compare
0ccd1ec to
246d9d2
Compare
246d9d2 to
dcf7c62
Compare
1004d3a to
3092d80
Compare
3092d80 to
29e38a4
Compare
8b27f78 to
8bacff0
Compare
keccakf precompile + GKR-IOP integration
b8e8476 to
8c29f04
Compare
c2b111b to
6b9015d
Compare
spherel
approved these changes
May 2, 2025
09a1808
into
scroll-tech:tianyi/refactor-prover
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is done against
tianyi/refactor-proverand not themasterbranch.Contains the following:
keccakfprecompile implementation.keccakfprecompile implementation.tianyi/refactor-proverin the existing Ceno proving flow.The lookup-based impl. is the superior one performance-wise; the bitwise one is rather a proof-of-concept and it might be relevant for benchmarking the proving system itself. The lookup version should be well documented by comments.
Some highlights of the integration code for
keccakf:LargeEcallDummycircuit which handles memory state by doing the appropriate reads and writes but does not connect them logically (doesn't get intokeccakf). The logic is handled by the GKR-IOP circuit.LargeEcallDummy. This ensures we can reuse the existing tower proofs inscheme/prover.rsand provides access to these polynomials for PCS logic.GKRIOPInstructiontrait, conceived as a subtrait ofInstruction. It generally makes calls to the corresponding methods inInstruction+ does some extra work to implement the functionality as described above. It also has some other methods useful for syncing state between the two protocols.Items that still need to be addressed to complete the integration:
LargeEcallDummy. However the opening logic is missing.