Skip to content

Feat/debug witness memory issue #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feat/debug witness memory issue #1238

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c210be4
debug witness memory issue
georgehao Sep 8, 2025
65024a9
bump version
georgehao Sep 8, 2025
f864b60
update
georgehao Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eth/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,13 +376,13 @@
return nil, fmt.Errorf("failed to validate block %d: %w", block.Number(), err)
}

if err = testWitness(blockchain, block, witness); err != nil {
return nil, err
}
//if err = testWitness(blockchain, block, witness); err != nil {
// return nil, err
//}
return witness, nil
}

func testWitness(blockchain *core.BlockChain, block *types.Block, witness *stateless.Witness) error {

Check failure on line 385 in eth/api.go

View workflow job for this annotation

GitHub Actions / check 

`testWitness` is unused (deadcode)
stateRoot := witness.Root()
diskRoot, err := rawdb.ReadDiskStateRoot(blockchain.Database(), stateRoot)
if err != nil && !errors.Is(err, leveldb.ErrNotFound) {
Expand Down
2 changes: 1 addition & 1 deletion params/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
const (
VersionMajor = 5 // Major version component of the current release
VersionMinor = 9 // Minor version component of the current release
VersionPatch = 4 // Patch version component of the current release
VersionPatch = 5 // Patch version component of the current release
VersionMeta = "mainnet" // Version metadata to append to the version string
)

Expand Down
Loading