Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(permissionless batches): batch production toolkit and operator recovery #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(permissionless batches): batch production toolkit and operator recovery #1555
Changes from all commits
dca69ce
2e09118
496314f
c12d380
c329959
71f240b
acc7083
59ea991
2df07a9
0f5ebf3
f96af8e
16a471d
d25094b
603feed
5ddd6d6
5ff6fd0
0108873
a6f914a
0123502
596d9fe
d85bdf5
a9eac08
606162e
30c0201
ec9d862
6ef4775
41606fe
0c0c417
78c9963
940fde0
ca8d930
421afe9
b460d4a
182f8e3
783b965
5a479c3
310abdd
2efbbd7
e713424
f4e17bc
99c0a9f
8db5339
69a80d4
5f22950
9412c7f
c3a3bad
2de45f0
f01af24
2bd0655
848d3a6
e5ad9c6
b424cef
ac17696
d503d4a
bf08436
83c73f8
d3acd6b
f13863e
8b57dd6
37924b0
fbc14ac
867fda6
2e9827a
01fa3b3
50ebf17
e1a0bab
bb9d404
0125dd6
121ce09
ed394a6
a55de1f
89ede0d
782e019
081d289
47a6c23
eb5758b
7353f30
673777f
554a233
e27ab5a
26a49cb
8ea4315
55b32e1
d6674e8
a1c4562
c8b614f
f91c999
82dd5e0
4333d51
b30f4d0
03c63a6
9f4c9ee
101cc46
a868bc1
8b08a57
f1ea4b3
b7e7d1a
94bee19
f27ddb7
da96331
d79aaef
ab7038c
47219f2
95adcc3
224546e
0799dd4
7a70e37
57d50b7
20dffe4
867307d
c9f6e8c
9b462e4
d57e6b0
4d677b3
90d1563
d987931
38b3239
e99a851
bb6ee2c
2d84478
a8511d5
a16b906
942f883
495921c
6414767
596fabf
81df41c
c2152b1
8009bd1
9d54bc2
ac3305c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray
--ccc
flag looks accidentalThe sample command includes
--ccc
, which does not exist in l2geth; this will cause the node to abort on unknown flag. Please drop or replace with the intended option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Authentication secret should not be hardcoded.
The authentication secret "prover secret key" appears to be a placeholder and should be replaced with a secure, randomly generated value in production.
Replace the hardcoded secret with an environment variable reference:
Then ensure this secret is provided through a secure method like environment variables or a secrets management system.
📝 Committable suggestion