Skip to content

Operational dialogue #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

grpinto
Copy link
Collaborator

@grpinto grpinto commented Mar 19, 2025

So, I essentially made DIALOGUE work with the toy example and without confounders which is not available in the original implementation. Things that still need to be done :

  • Allow multiple confounders, currently we can only handle the original cellQ and none
  • Improve the input output structure, currently it only creates a big dictionary similar to what is done in the R version, but I think this can be streamlined very easily by using an anndata
  • Improve the performance time for real datasets (dialogue toy example runs fast). Major chokepoints is in the stats model regression in multilevel modelling
  • We also need to implement one additional function in Dialogue called pheno which seems to me to be a summary of the results

** Very important **

To run Dialogue notebooks you can get the MCPs simply by accessing to the "residual_scores" key of the output dictionary of DIALOGUE1 I have tried it myself and it works fine. I changed the Test association function so it can run with the result from calculate_multifactor_PMD with the kay "residual_scores" you just need to provide it to the function

Changes performed :

  • Defined a lot of new functions, they are too many to refer here, but I think the code works fine. Can do if really necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant