feat: nicheVI release #3172
feat: nicheVI release #3172
Conversation
for more information, see https://pre-commit.ci
| raise ValueError("Must provide either n_obs_minibatch or reconstruction_loss") | ||
|
|
||
| default = 0 * self.loss | ||
| if self.reconstruction_loss is None: |
There was a problem hiding this comment.
seems to me those next lines can be simply re-written in a for loop of different attributes, all is going under same thing (but I guess we need to fix also original class)
There was a problem hiding this comment.
a tutorial and model description doc are missing
src/scvi/external/nichevi/differential_expression/_dataclass.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
this is also already exists for the main use of DE. why do we need to have this duplications?
Can't it be inherited from updated DE , init and adjusted locally with those parameters? will save alot of code.
There was a problem hiding this comment.
Too many changes due to the neighbor computations, renamed it to _niche_de_core
ori-kron-wis
added
on-merge: backport to 1.3.x
|
please also add changelog record, links to tutorials and model descriptions (see other models that were merged recently like resolvi, sysvi) |
No description provided.