Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get_norm function property #3238

Merged
merged 7 commits into from
Mar 9, 2025
Merged

Conversation

ori-kron-wis
Copy link
Collaborator

added get_norm property and check for all models + also the criticism guide

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.3.x on-merge: backport to 1.3.x label Mar 5, 2025
@ori-kron-wis ori-kron-wis requested a review from canergen March 5, 2025 15:52
@ori-kron-wis ori-kron-wis self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (bf8daf4) to head (7b0b94b).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (80.69%) is below the target coverage (83.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (bf8daf4) and HEAD (7b0b94b). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (bf8daf4) HEAD (7b0b94b)
29 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3238      +/-   ##
==========================================
- Coverage   87.32%   80.69%   -6.64%     
==========================================
  Files         193      193              
  Lines       17067    17079      +12     
==========================================
- Hits        14904    13782    -1122     
- Misses       2163     3297    +1134     
Files with missing lines Coverage Δ
src/scvi/external/cellassign/_model.py 92.30% <100.00%> (ø)
src/scvi/external/gimvi/_model.py 91.70% <100.00%> (ø)
src/scvi/external/methylvi/_methylanvi_model.py 89.23% <100.00%> (+0.16%) ⬆️
src/scvi/external/methylvi/_methylvi_model.py 76.81% <100.00%> (+0.34%) ⬆️
src/scvi/external/poissonvi/_model.py 73.07% <100.00%> (+0.34%) ⬆️
src/scvi/external/sysvi/_model.py 88.67% <ø> (ø)
src/scvi/hub/_template.py 100.00% <ø> (ø)
src/scvi/model/_autozi.py 95.40% <100.00%> (ø)
src/scvi/model/_destvi.py 85.47% <ø> (-0.37%) ⬇️
src/scvi/model/_multivi.py 75.25% <100.00%> (+0.08%) ⬆️
... and 2 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit c538dbc into main Mar 9, 2025
16 of 17 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 9, 2025
ori-kron-wis added a commit that referenced this pull request Mar 9, 2025
…3242)

Backport PR #3238: feat: get_norm function property

Co-authored-by: Ori Kronfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant