Skip to content

ci: build in release #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

ci: build in release #282

merged 1 commit into from
Apr 24, 2025

Conversation

muzarski
Copy link
Collaborator

In hope to speed up the CI process.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

In hope to speed up the CI process.
@muzarski
Copy link
Collaborator Author

I'm comparing with: #280

For Scylla ITs, we see significant improvement from 14-17 minutes to 9-12 minutes. Unfortunately, the slowest job (cassandra tests) is still slow... We see an improvement (21 minutes to 17 minutes), so we at least gain something. The cassandra tests are bounded by slow ccm cluster operations. Take for example: ConsistencyThreeNodeClusterTests.Integration_Cassandra_TwoNodesDecommissioned (146438 ms) - over 2 minutes for 1 test case !!!!!!!

I still think it is worth merging. We gain around 4 minutes per CI run.

@muzarski muzarski requested review from Lorak-mmk and wprzytula April 24, 2025 11:24
@muzarski muzarski added this to the 0.5 milestone Apr 24, 2025
@muzarski muzarski self-assigned this Apr 24, 2025
@muzarski muzarski added CI Related to continuous integration area/testing Related to unit/integration testing labels Apr 24, 2025
@muzarski muzarski merged commit f634a8a into scylladb:master Apr 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to unit/integration testing CI Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants