forked from datastax/python-driver
-
Notifications
You must be signed in to change notification settings - Fork 48
cluster: add application_info #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkropachev
wants to merge
1
commit into
master
Choose a base branch
from
dk/485-report-application-information-to-server
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an integration test running on C* that uses the new API and verifies the data in client_info
.
d7d7385
to
7e0a9d2
Compare
Lorak-mmk
requested changes
Jun 6, 2025
7e0a9d2
to
bb58890
Compare
bb58890
to
1c8fb4f
Compare
Implement clustr.application_info to make driver send following startup options to server: 1. `APPLICATION_NAME` - ID what application is using driver, example: repo of the application 2. `APPLICATION_VERSION` - Version of the application, example: release version or commit id of the application 3. `CLIENT_ID` - unique id of the client instance, example: pod name All strings.
1c8fb4f
to
276b6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement clustr.application_info to make driver send following startup options to server:
APPLICATION_NAME
- ID what application is using driver, example: repo of the applicationAPPLICATION_VERSION
- Version of the application, example: release version or commit id of the applicationCLIENT_ID
- unique id of the client instance, example: pod nameAll strings.
Fix: #485
Results:
Pre-review checklist
I added relevant tests for new features and bug fixes.I have adjusted the documentation in./docs/source/
.Fixes:
annotations to PR description.