feat(manager docker) switch to be based on ubi9-minimal #4244
Conversation
To achieve OpenShift certification for the Scylla-Operator, our Scylla Manager container images need to be based on Red Hat's UBI images. Fixes: #4242
yaronkaikov
requested review from
karol-kokoszka,
Michal-Leszczynski and
VAveryanov8
as code owners
|
@karol-kokoszka can we merge this? |
|
Yes, we can. |
|
@yaronkaikov does this PR fix #4242? I'm asking in the context of this comment. |
|
This PR isn't enough to close #4242 - the preflight check won't pass, at least the labels are missing. |
probably not, but we can send a follow-up patches to make it right. Just not sure when |
|
follow-up sounds good 👍. Good to see manager on UBI, however the entire list (at least the labels) is a blocking requirement for openshift certification as well. So we'll need to get it scheduled somehow. @yaronkaikov could you please reopen #4242 so that we don't lose track of the tail end? |
|
I re-opened it |
| @@ -1,15 +1,13 @@ | |||
| FROM ubuntu | |||
| ARG ARCH=amd64 | |||
| FROM docker.io/redhat/ubi9-minimal:latest | |||
There was a problem hiding this comment.
Should have used quay.io really.
It's unclear why we use latest, but we can review this decision later.
There was a problem hiding this comment.
In fact, we should use registry.access.redhat.com/ubi9/ubi-minimal:latest
| apt-get clean && \ | ||
| RUN microdnf update && \ | ||
| microdnf -y upgrade && \ | ||
| microdnf install -y ca-certificates && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Is this the way to clean microdnf residue?
I thought it is
microdnf clean all
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY release/scylla-manager-agent*$ARCH.deb / | ||
| RUN dpkg -i scylla-manager-agent*$ARCH.deb && rm /scylla-manager-agent*.deb | ||
| COPY release/scylla-manager-agent*$ARCH.rpm / |
There was a problem hiding this comment.
This creates another layer, which I assume we don't squash later?
|
@yaronkaikov apologies for not reviewing this, but I have left some comments. I believe we need a follow-up to this work - shall I open another issue? |
I have re-opened the original issue since we are missing some labels for the certification, please add relevant info there, or open a new one. |
To achieve OpenShift certification for the Scylla-Operator, our Scylla Manager container images must be based on Red Hat's UBI images.
Fixes: #4242