Retry DLL queries upon group 0 concurrent modification error #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Despite previous measures (sending all DDL queries to a single node) this error is still haunting our CI. I see no better way of patching this on our side than retrying. Core really should do something about it :(
dkropachev
approved these changes
Feb 3, 2025
wprzytula
approved these changes
Feb 4, 2025
mykaul
reviewed
Feb 4, 2025
| // In this case we really should do something about it in the | ||
| // core, because it is absurd for DDL queries to fail this often. | ||
| if self.count >= 10 { | ||
| error!("Received TENTH(!) group 0 concurrent modification error during DDL. Please fix Scylla Core."); |
There was a problem hiding this comment.
Please file a bug on Scylla Core (and attach logs!)
There was a problem hiding this comment.
I did that ~2 months ago: scylladb/scylladb#21779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite previous measures (sending all DDL queries to a single node) this error is still haunting our CI. I see no better way of patching this on our side than retrying.
Pre-review checklist
added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.