-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: Allows filtering by dynamic labels #1461
Open
amnonh
wants to merge
1
commit into
scylladb:master
Choose a base branch
from
amnonh:filter_by_relabel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes. I don't follow this change and to be honest -- I don't even follow the code before this change :(
When registering new metrics, the
if (_value_map.find(name) != _value_map.end()) {
from above would evaluate tofalse
so we get into the else branch and skip the_labels.insert()
before the patch, but make insertions after it. What's going on here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xemul Let me try to explain, the metrics layer holds a set of all available labels.
This way, if some queries for a specific label value (i.e. Prometheus API), it can check if this label exists.
Recently, a new API was added to the metrics layer that would allow dynamically add or change label values.
Following that change it's possible that someone register a metrics with specific labels, but because of relabel_config more labels were added.
The series address this situations, it always tries to update the set of labels.
Overall there's little impact on performance, metrics are registered once, and most of them during startup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's clear, thanks. However, I still don't get why the
appeared in the
impl::add_registration
's "else" branch only now. Before this change, if a new metrics is added, its labels were not added to the_labels
set?Yes, of course. Performance is not of interest here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up until now, metrics were static, so it was enough to look for labels the first time a metric was added. However, maybe this assumption is wrong to begin with, and this is a bug (i.e., it shouldn't have been conditional in the first place).
I hit that limitation when I tested adding labels dynamically and managed to get to a situation where I could add a label, but I couldn't filter by it.