build: support enabled options when building seastar-module #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can have access to the Seastar_PRIVATE_CXX_FLAGS when defining the `seastar-module` target. we will do this in another commit. Signed-off-by: Kefu Chai <[email protected]>
before this change, when building with C++20 modules enabled, some symbols are not accessible, when compiling source files like src/core/resource.cc if some features are enabled using macros like SEASTAR_HAVE_HWLOC and SEASTAR_HAVE_URING. in this change, we include the missing headers or move the include precessor directives, so that the .cc files can have access to the used declaration of the used symbols. please note, this change not only enables us to build C++20 modules with SEASTAR_HAVE_HWLOC and/or SEASTAR_HAVE_URING defined, it is also necessary also from the correctness point of view. Signed-off-by: Kefu Chai <[email protected]>
before this change, when building seastar-module, we don't check for the enabled features. so, for instance io uring backend is not enabled even `Seastar_IO_URING` is set. in this change we * check for the enabled options, * link against the related libraries, and * add the required macro definitions this should enable seastar-module to build with, for instance, io_uring backend enabled. as `SEASTAR_HAVE_URING` enables this backend when building `src/core/reactor_backend.cc`. Fixes scylladb#2249 Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, when building seastar-module, we don't check for
the enabled features. so, for instance io uring backend is not enabled
even
Seastar_IO_URINGis set.in this series we
add_subdirectory(src)down#includethe used header filesthis should enable seastar-module to build with, for instance, io_uring
backend enabled. as
SEASTAR_HAVE_URINGenables this backend whenbuilding
src/core/reactor_backend.cc.Fixes #2249