posix-file-impl: Do not keep device-id on board #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This number is needed in two places - construction-time, to find the io-queue object to use - run-time, to construct file handle File handle uses device id to create another posix_file_impl object on another shard, so it needs device id to find io-queue for it. However, when creating handle, the deivce-id can be obtained by file from the io-queue it references. Signed-off-by: Pavel Emelyanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This number is needed in two places
File handle uses device id to create another posix_file_impl object on another shard, so it needs device id to find io-queue for it. However, when creating handle, the deivce-id can be obtained by file from the io-queue it references.