Fix compilation failure on Ubuntu 22.04 #2274
Conversation
| @@ -28,6 +28,7 @@ | |||
| #include <algorithm> | |||
| #include <memory> | |||
| #include <cassert> | |||
| #include <optional> | |||
There was a problem hiding this comment.
hi Patryk, could you check if it's necessary to include seastar/util/std-compat.hh in these header files? for instance, when preparing #2273, i audited include/seastar/core/ragel.hh to see if it's still referencing any of the headers provided by seastar/util/std-compat.hh, if not, we should drop #include <seastar/util/std-compat.hh> in that header.
There was a problem hiding this comment.
and thank you for the fix!
There was a problem hiding this comment.
Sure, I will do it in a moment 👍
There was a problem hiding this comment.
also, might want to reference the commit which introduced this regression in the commit message.
There was a problem hiding this comment.
@tchaikov - the PR has been adjusted according to your comments 👍
When the code was built according to the README.md on Ubuntu 22.04 it failed due to missing includes of <optional> and <variant>. Commit b822c94 seemed to be the first for which the issue occurred. This change adds missing includes and removes usage of "std-compat.hh" in modified files when possible. Signed-off-by: Patryk Wrobel <[email protected]>
pwrobelse
force-pushed
the
includes-fix-missing-optional-and-variant
branch
from
35198ac to
e48b3d3
Compare
|
@xemul hi Pavel, could you please take a look? i would like to prepare a PR to bump up the seastar submodule so that we can be avoid the potential build failures where some of the source files fail to include |
Fix compilation failure on Ubuntu 22.04
When the code was built according to the
README.md on Ubuntu 22.04 it failed due
to missing includes of
<optional>and<variant>.Commit b822c94
seemed to be the first for which the issue
occurred.
This change adds missing includes and removes
usage of "std-compat.hh" in modified files when
possible.