Add zendesk tag support #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarcia360
added a commit
to dgarcia360/scylla-manager
that referenced
this pull request
Jan 9, 2024
Related: scylladb/sphinx-scylladb-theme#979 Adds the Zendesk tag to index.html page ## How to test 1. Run `make multiversion`. 1. Open the `_build/dirhtml/index.html` file. 1. Check for the presence of the Zendesk tag associated with this project.
This was referenced Jan 9, 2024
karol-kokoszka
pushed a commit
to scylladb/scylla-manager
that referenced
this pull request
Jan 11, 2024
Related: scylladb/sphinx-scylladb-theme#979 Adds the Zendesk tag to index.html page ## How to test 1. Run `make multiversion`. 1. Open the `_build/dirhtml/index.html` file. 1. Check for the presence of the Zendesk tag associated with this project.
Michal-Leszczynski
pushed a commit
to scylladb/scylla-manager
that referenced
this pull request
Jan 17, 2024
Related: scylladb/sphinx-scylladb-theme#979 Adds the Zendesk tag to index.html page ## How to test 1. Run `make multiversion`. 1. Open the `_build/dirhtml/index.html` file. 1. Check for the presence of the Zendesk tag associated with this project. (cherry picked from commit d837629)
|
@annastuchlik @dgarcia360 , please note that the meta-tag for the Manager docs was changed last week and I mistakenly deleted the previous crawler with its meta tag. Below is the correct tag, can you please edit the existing PR or create a new PR for it? Thanks! |
Michal-Leszczynski
pushed a commit
to scylladb/scylla-manager
that referenced
this pull request
Jan 19, 2024
Related: scylladb/sphinx-scylladb-theme#979 Adds the Zendesk tag to index.html page ## How to test 1. Run `make multiversion`. 1. Open the `_build/dirhtml/index.html` file. 1. Check for the presence of the Zendesk tag associated with this project. (cherry picked from commit d837629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets projects specify custom Zendesk tags in their
conf.pyfile as follows:Different from the previous approach, the tag is added to the main
index.htmlfile that handles redirections.How to test
Run
make multiversion.Open the
_build/dirhtml/index.htmlfile.Check for the presence of the Zendesk tag associated with this project: