Skip to content

Add code evaluation settings for blink and post evaluate message #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okhick wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add code evaluation settings for blink and post evaluate message #13

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b79db0b
Tweak decorator timeout and clear
okhick Mar 25, 2023
00f78a2
Setup clang-format autosave
okhick Mar 25, 2023
04df83a
Merge remote-tracking branch 'forked/develop' into develop
okhick Apr 9, 2023
04fe564
Merge branch 'develop' into evaluation-decorator-tweaks
okhick Apr 10, 2023
4baf384
Make blinkDuration a setting
okhick Apr 10, 2023
6d5f388
Add toggle for post-execution message
okhick Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/evaluate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ const errorDecorator = vscode.window.createTextEditorDecorationType({
outline : 'border-left-width: 1px',
isWholeLine : true,
});
let evaluateCount = 0;
const decoratorTimeout = 5000;
let evaluateCount = 0;
const decoratorTimeout = 600;

// Start and end execution actions
function onEndEvaluate(textEditor: TextEditor, range: Range, responseText: string, isError: boolean)
Expand Down Expand Up @@ -84,7 +84,7 @@ function onStartEvaluate(textEditor: TextEditor, range: Range)
}, decoratorTimeout);

return (text: string, isError: boolean) => {
if (evaluateCount == currentEvaluateCount)
if (evaluateCount != currentEvaluateCount)
Copy link
Copy Markdown
Contributor Author

@okhick okhick Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is a copy/paste error from line 80.

{
onEndEvaluate(textEditor, range, text, isError)
}
Expand Down