Skip to content

V2: arm64: dts: qcom: common dtsi for Xiaomi SDM660-family#169

Open
M0Rf30 wants to merge 7 commits intosdm660-mainline:masterfrom
M0Rf30:upstreaming/xiaomi-common-v2
Open

V2: arm64: dts: qcom: common dtsi for Xiaomi SDM660-family#169
M0Rf30 wants to merge 7 commits intosdm660-mainline:masterfrom
M0Rf30:upstreaming/xiaomi-common-v2

Conversation

@M0Rf30
Copy link
Copy Markdown

@M0Rf30 M0Rf30 commented Jan 21, 2026

No description provided.

Add device tree bindings for:
- Xiaomi Redmi Note 6 Pro (tulip) - SDM636
- Xiaomi Redmi Note 5 Pro (whyred) - SDM636
- Xiaomi Mi A2 (jasmine) - SDM660
- Xiaomi Mi 8 Lite (platina) - SDM660

These are Android-based smartphones that can boot mainline Linux
with simple-framebuffer and USB support.

Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
@minlexx
Copy link
Copy Markdown
Member

minlexx commented Jan 22, 2026

It may be very beneficial to try to put regulators settings in -common. That is, unless there is some serious difference? They should be the same mostly I hope.

@M0Rf30 M0Rf30 force-pushed the upstreaming/xiaomi-common-v2 branch 4 times, most recently from 49d8e68 to da340c9 Compare January 25, 2026 14:35
@M0Rf30 M0Rf30 requested a review from minlexx January 25, 2026 14:37
@M0Rf30 M0Rf30 force-pushed the upstreaming/xiaomi-common-v2 branch from da340c9 to da779bc Compare January 25, 2026 15:12
Create a shared device tree include file for Xiaomi smartphones and tablets
based on Qualcomm SDM636/SDM660 SoCs. This reduces code duplication when
adding new Xiaomi devices and ensures consistent configuration across the
family.

The common dtsi includes:
- PM660/PM660L PMIC regulators (common switchers s1, s2, s4, s5, s6 and l7)
- PM660/PM660L PMIC configuration with volume/power buttons
- Serial console (blsp1_uart2, blsp2_uart1)
- Hall effect sensor (disabled by default)
- USB (qusb2phy0, usb3) in peripheral mode
- SD card (sdhc_2) pinctrl and supplies
- eMMC (sdhc_1) with HS400 support
- Backlight (pm660l_wled)
- Framebuffer memory reservation
- WiFi (wcn3990)
- Bluetooth (wcn3990)

Also refactor sdm660-xiaomi-lavender.dts to use the new common include,
removing duplicated code.

Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Adjust lavender-specific regulator settings:
- vreg_l2b_2p95: Increase max voltage from 2696mV to 3100mV to support
  proper SD card voltage signaling
- vreg_l3b_3p3: Add regulator-always-on to keep the regulator enabled
- vreg_l10a_1p8: Add regulator-system-load for proper USB PHY PLL operation

Enable the SD card controller (sdhc_2) which was previously disabled.

Note: Common regulator definitions (switchers s1, s2, s4, s5, s6) are now
inherited from sdm660-xiaomi-common.dtsi; this file only contains
device-specific LDO configurations.

Co-developed-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Add initial device tree support for the Xiaomi Redmi Note 6 Pro
(codename: tulip), a smartphone based on Qualcomm SDM636 SoC with
4GB RAM and a 6.26" 1080x2280 display.

This enables:
- Booting to a framebuffer console
- USB support
- Hall effect sensor
- Touchscreen (Novatek NT36672A)
- Battery monitoring
- Charging (pm660_charger)
- Status LED (pm660l_lpg)

Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Add initial device tree support for the Xiaomi Redmi Note 5 Pro
(codename: whyred), a smartphone based on Qualcomm SDM636 SoC with
4/6GB RAM and a 5.99" 1080x2160 display.

This enables:
- Booting to a framebuffer console
- USB support
- Hall effect sensor
- Touchscreen (Synaptics RMI4)
- Battery monitoring
- Charging (pm660_charger)
- Status LED (pm660l_lpg)

Co-developed-by: Mathesh Velayudan <123v.mathesh@gmail.com>
Signed-off-by: Mathesh Velayudan <123v.mathesh@gmail.com>
Co-developed-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Add initial device tree support for the Xiaomi Mi A2
(codename: jasmine), a smartphone based on Qualcomm SDM660 SoC with
4/6GB RAM and a 5.99" 1080x2160 display.

This enables:
- Booting to a framebuffer console
- USB support
- Touchscreen (Novatek NT36672A)
- Battery monitoring
- Charging (pm660_charger)

Note: Hall effect sensor is disabled on this device.

Co-developed-by: Joe Mason <buddyjojo06@outlook.com>
Signed-off-by: Joe Mason <buddyjojo06@outlook.com>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Add initial device tree support for the Xiaomi Mi 8 Lite
(codename: platina), a smartphone based on Qualcomm SDM660 SoC with
4/6GB RAM and a 6.26" 1080x2280 display.

This enables:
- Booting to a framebuffer console
- USB support
- Hall effect sensor
- Touchscreen (Novatek NT36672A)
- Battery monitoring
- Charging (pm660_charger)

Co-developed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Co-developed-by: Molly Sophia <mollysophia379@gmail.com>
Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
@M0Rf30 M0Rf30 force-pushed the upstreaming/xiaomi-common-v2 branch from da779bc to 4351be9 Compare January 25, 2026 15:32
@minlexx
Copy link
Copy Markdown
Member

minlexx commented Feb 7, 2026

So, for the commit that fixes regulators on lavender, they're saying here that regulator-system-load deserves a comment and an explanation.

So, 💭

  • in commit message instead of - vreg_l10a_1p8: Add regulator-system-load for proper USB PHY PLL operation maybe something like - vreg_l10a_1p8: Add regulator-system-load to avoid board reset when plugging USB cable
  • ... and perhaps the same comment in dts?.. 🤔 for each and every DT with regulator-system-load = <14000>; under l10a.

🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants