Skip to content

arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel regulators, and syna ts#174

Merged
sajattack merged 5 commits intosdm660-mainline:qcom-sdm660-6.18.yfrom
sajattack:saj/bbry/fix-reserved-mem
Mar 13, 2026
Merged

arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel regulators, and syna ts#174
sajattack merged 5 commits intosdm660-mainline:qcom-sdm660-6.18.yfrom
sajattack:saj/bbry/fix-reserved-mem

Conversation

@sajattack
Copy link
Copy Markdown

@sajattack sajattack commented Mar 9, 2026

Passes memtest now. Copied from downstream with some tweaks. Tested remoteproc and wifi still work.

Also adding lcd panel regulators to fix syna flakiness and tweaking touchscreen delays.

@minlexx
Copy link
Copy Markdown
Member

minlexx commented Mar 9, 2026

Adds ton of new errors to dtbs-check (see checks tab), plz fix 👉 👈

@sajattack sajattack force-pushed the saj/bbry/fix-reserved-mem branch 3 times, most recently from da413b6 to 7c8891c Compare March 10, 2026 04:05
@sajattack sajattack marked this pull request as draft March 10, 2026 07:56
@sajattack sajattack force-pushed the saj/bbry/fix-reserved-mem branch from 7c8891c to e507bae Compare March 10, 2026 08:42
@sajattack sajattack marked this pull request as ready for review March 10, 2026 08:42
@setotau
Copy link
Copy Markdown

setotau commented Mar 10, 2026

@minlexx
Copy link
Copy Markdown
Member

minlexx commented Mar 10, 2026

Lexical error: Documentation/devicetree/bindings/display/panel/boe,bv045fhm-l00.example.dts:29.35-50 Unexpected 'GPIO_ACTIVE_LOW'

Forgottent #include for GPIO_ACTIVE_LOW definition? in bindings example..?

@sajattack sajattack changed the title arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel, and ts Mar 10, 2026
@sajattack sajattack changed the title arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel, and ts arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel, and syna ts Mar 10, 2026
@sajattack sajattack changed the title arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel, and syna ts arm64: dts: qcom: sdm660-bbry-common: fix reserved-mem ranges, panel regulators, and syna ts Mar 10, 2026
@sajattack sajattack force-pushed the saj/bbry/fix-reserved-mem branch from e507bae to 5ef8b40 Compare March 12, 2026 01:44
@sajattack sajattack force-pushed the saj/bbry/fix-reserved-mem branch from 5ef8b40 to 50a820c Compare March 12, 2026 02:25
vdd-supply = <&lcdb_fixed>;
reset-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
syna,reset-delay-ms = <220>;
syna,startup-delay-ms = <2000>;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge delay :))

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing to init if the display wasn't ready.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels too much, 1000 isn't enough?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tried 1200 at one point. Before it was at 600. 2000 seemed good for stability.

@minlexx
Copy link
Copy Markdown
Member

minlexx commented Mar 12, 2026

Would be even better if you could test the same change on top of setotau's 6.19.y branch and by doing so try 6.19 in general

@sajattack
Copy link
Copy Markdown
Author

Would be even better if you could test the same change on top of setotau's 6.19.y branch and by doing so try 6.19 in general

I tested some of the changes on 7.0.0 already, but I can do that too.

@setotau
Copy link
Copy Markdown

setotau commented Mar 12, 2026

I tested some of the changes on 7.0.0 already, but I can do that too.

I think I'll rebase on 7.0.0 soon

@sajattack
Copy link
Copy Markdown
Author

sajattack commented Mar 12, 2026

Ugh, I tried booting 6.19 on the athena-syna variant, and memtest got stuck again. I have more work to do.

@sajattack
Copy link
Copy Markdown
Author

sajattack commented Mar 12, 2026

Ugh, I tried booting 6.19 on the athena-syna variant, and memtest got stuck again. I have more work to do.

false alarm, missed one of the commits in the cherry-pick, 6.19 looks good

key2:~$ uname -a
Linux key2 6.19.6-sdm660 #36 SMP PREEMPT Thu Mar 12 19:12:54 UTC 2026 aarch64 GNU/Linux
key2:~$ cat /proc/cmdline
initrd=initramfs loglevel=7 debug memtest=1 pmos.nosplash pmos_boot_uuid=B3EA-D7F3 pmos_root_uuid=89a16591-50d9-4d9a-9ac4-e941f32b5aac pmos_rootfsopts=defaults

@sajattack sajattack merged commit 6122359 into sdm660-mainline:qcom-sdm660-6.18.y Mar 13, 2026
3 checks passed
@setotau
Copy link
Copy Markdown

setotau commented Mar 13, 2026

cherry-picked and merged into 6.19. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants