Repository navigation
Fix two cloud-browser specs that failed locally after #305 - #317
Merged
Merged
Conversation
- next-feed "every old kind renders": comment text used white-space: pre-wrap, so a space at a wrap point hangs past its box (4 px at 320 px with macOS Chrome fonts; Linux CI fonts wrap elsewhere). Use break-spaces, which wraps that space instead. Same change for the history note and saved game note. - comparisons-home settings tests: a confirmed save is three local-database round trips; on a loaded machine they outlast the 5 s default wait. Give the "Settings saved." confirmation 15 s; the assertion itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
seanbalz
marked this pull request as ready for review
October 29, 2026 00:27
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Playwright cloud-browser tests failed in a local run while verifying #305. CI passed them. Each one was run alone to find the cause.
next-feed.spec.js "every old kind renders…": a real layout defect, seen only with macOS fonts
feed-thread dark 320reportedspan "Week is open, get your picks in": text leaves its box..gx-feed-cm-textusedwhite-space: pre-wrap. With pre-wrap, a space at a wrap point hangs past the line box. At 320 px, macOS Chrome wraps right after "your ". The measured line rects were[118.6, 287.5], then a 4 px[287.5, 291.5]for the space, and the box ends at 288. Linux CI fonts wrap somewhere else, so CI never saw it.white-space: break-spaces. Spaces and newlines are still kept, but a space at the end of a line now wraps to the next line instead of hanging..gx-history-noteand.gx-game-note-savedhad the same latent issue and got the same one-line change.tests/helpers/phone-layout.mjs) is unchanged.comparisons-home.spec.js "settings retain the draft on a concurrent account write…": a timing problem under load
me/preferences*request by 1.8 s made the original assertion fail with the reported symptom (getByText('Settings saved.')not found). With the fix, the same run passes.SAVE_ROUND_TRIPS = 15_000. The assertion is the same; only the wait is longer. No privacy or leak check was touched.Verification
npx playwright test --config playwright.cloud.config.jswith both specs and--repeat-each 3(port moved to 5231 in a local config copy that is not committed): 17 of 18 passed. Both target tests passed 3 out of 3. The one failure was the first, cold run ofcomparisons-home.spec.js:28at load about 60: setup used up the whole 30 s test timeout before sign-in. It passed the other two repeats. That is general machine load, not this change.npm test: green (vitest 468/468; the node suites passed)..local/sql-check; without it these specs skip.🤖 Generated with Claude Code