Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ tokio-tungstenite = { version = "0.21", optional = true }
percent-encoding = "2.1"
pin-project = "1.0"
tokio-rustls = { version = "0.26", default-features = false, features = ["logging", "tls12", "ring"], optional = true }
rustls-pemfile = { version = "2.0", optional = true }

[dev-dependencies]
pretty_env_logger = "0.5"
Expand All @@ -56,7 +55,7 @@ listenfd = "1.0"
default = ["multipart", "websocket"]
multipart = ["multer"]
websocket = ["tokio-tungstenite"]
tls = ["tokio-rustls", "rustls-pemfile"]
tls = ["tokio-rustls"]

# Enable compression-related filters
compression = ["compression-brotli", "compression-gzip"]
Expand Down
23 changes: 14 additions & 9 deletions src/tls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use tokio::io::{AsyncRead, AsyncWrite, ReadBuf};
use futures_util::ready;
use hyper::server::accept::Accept;
use hyper::server::conn::{AddrIncoming, AddrStream};
use tokio_rustls::rustls::pki_types::{self, pem::PemObject};
use tokio_rustls::rustls::server::WebPkiClientVerifier;
use tokio_rustls::rustls::{Error as TlsError, RootCertStore, ServerConfig};

Expand Down Expand Up @@ -173,7 +174,7 @@ impl TlsConfigBuilder {

pub(crate) fn build(mut self) -> Result<ServerConfig, TlsConfigError> {
let mut cert_rdr = BufReader::new(self.cert);
let cert = rustls_pemfile::certs(&mut cert_rdr)
let cert = pki_types::CertificateDer::pem_reader_iter(&mut cert_rdr)
.collect::<Result<Vec<_>, _>>()
.map_err(|_e| TlsConfigError::CertParseError)?;

Expand All @@ -188,14 +189,15 @@ impl TlsConfigBuilder {

let mut key_opt = None;
let mut key_cur = std::io::Cursor::new(key_vec);
for item in rustls_pemfile::read_all(&mut key_cur)
.collect::<Result<Vec<_>, _>>()
while let Some((kind, data)) = pki_types::pem::from_buf(&mut key_cur)
.map_err(|_e| TlsConfigError::InvalidIdentityPem)?
{
match item {
rustls_pemfile::Item::Pkcs1Key(k) => key_opt = Some(k.into()),
rustls_pemfile::Item::Pkcs8Key(k) => key_opt = Some(k.into()),
rustls_pemfile::Item::Sec1Key(k) => key_opt = Some(k.into()),
use pki_types::{pem::SectionKind, PrivateKeyDer};

match kind {
SectionKind::PrivateKey => key_opt = Some(PrivateKeyDer::Pkcs8(data.into())),
SectionKind::RsaPrivateKey => key_opt = Some(PrivateKeyDer::Pkcs1(data.into())),
SectionKind::EcPrivateKey => key_opt = Some(PrivateKeyDer::Sec1(data.into())),
_ => return Err(TlsConfigError::UnknownPrivateKeyFormat),
}
}
Expand All @@ -209,9 +211,12 @@ impl TlsConfigBuilder {
) -> Result<RootCertStore, TlsConfigError> {
let trust_anchors = {
let mut reader = BufReader::new(trust_anchor);
rustls_pemfile::certs(&mut reader)
pki_types::CertificateDer::pem_reader_iter(&mut reader)
.collect::<Result<Vec<_>, _>>()
.map_err(TlsConfigError::Io)?
.map_err(|e| match e {
pki_types::pem::Error::Io(e) => TlsConfigError::Io(e),
_ => TlsConfigError::CertParseError,
})?
};

let mut store = RootCertStore::empty();
Expand Down