AstVisitor corrections #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found two minor issues related to
AstVisitorin the recent commits:VisitExportAllDeclarationwas not updated by Support ES2020 export ns from #196 to include the visitation of the newExportAllDeclaration.Exportedproperty.VisitStaticBlockis rather questionable because it adds redundancy (at least, from the visitor's POV).StaticBlockis just a special case ofBlockStatement, has no additional attributes. In such cases we (usually) haven't introduced dedicated visit methods, just left it to the base class to handle the visitation aspect. For example, in the cases ofExpressionStatementandDirectiveorMemberExpressionandStaticMemberExpression. I think it'd be a good idea to keep up this convention.