Skip to content

Conversation

akleshchev
Copy link
Contributor

I'm not sure if this is a good idea, but it's the simplest approch in circumstances where I can't test this.

Copy link

@callumlinden callumlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - simple, effective. LGTM.

Copy link

@callumlinden callumlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - simple, effective. LGTM.

Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. But maybe we should also add some "File not found" logging here.

@akleshchev
Copy link
Contributor Author

But maybe we should also add some "File not found" logging here.

Done, thank you.

@akleshchev akleshchev merged commit 220c88d into main Sep 3, 2025
4 checks passed
@akleshchev akleshchev deleted the dullahan_update branch September 3, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants