Skip to content

fix: missed changes and UI bugs for 148 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoyalOughtness merged 3 commits into from
May 5, 2026
+38 −3
Merged

fix: missed changes and UI bugs for 148 #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab5bbd9
Update hide-useless-prefs.patch
RKNF404 May 5, 2026
d34d5fe
Update hide-privacy-intrusive-prefs.patch
RKNF404 May 5, 2026
83fbe37
Update dns-providers.patch
RKNF404 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions patches/dns-providers.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ index 386c76b3c8..eaaec51147 100644
"2606:4700:4700::1003"},
{"family.cloudflare-dns.com"},
"https://family.cloudflare-dns.com/dns-query",
/*ui_name=*/"",
- /*ui_name=*/"",
+ /*ui_name=*/"Cloudflare Family (1.1.1.3)",
/*privacy_policy=*/"",
- /*display_globally=*/false,
+ /*display_globally=*/true,
Expand All @@ -60,7 +61,8 @@ index 386c76b3c8..eaaec51147 100644
"2606:4700:4700::1002"},
{"security.cloudflare-dns.com"},
"https://security.cloudflare-dns.com/dns-query",
/*ui_name=*/"",
- /*ui_name=*/"",
+ /*ui_name=*/"Cloudflare Security (1.1.1.2)",
/*privacy_policy=*/"",
+ /*display_globally=*/true,
+ /*display_countries=*/{},
Expand Down
11 changes: 10 additions & 1 deletion patches/ui_patches/hide-privacy-intrusive-prefs.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,18 @@ index 220bfa52fa..076c4ec3dc 100644
label="$i18n{importTitle}"
on-click="onImportDataClick_"></cr-link-row>
diff --git a/chrome/browser/ui/webui/settings/settings_ui.cc b/chrome/browser/ui/webui/settings/settings_ui.cc
index 19aebba1df..8e5c62ff84 100644
index 19aebba1df..45d59b65ec 100644
--- a/chrome/browser/ui/webui/settings/settings_ui.cc
+++ b/chrome/browser/ui/webui/settings/settings_ui.cc
@@ -346,7 +346,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
bool show_privacy_guide =
base::FeatureList::IsEnabled(features::kPrivacyGuideForceAvailable) ||
(!ShouldDisplayManagedUi(profile) && !profile->IsChild());
- html_source->AddBoolean("showPrivacyGuide", show_privacy_guide);
+ html_source->AddBoolean("showPrivacyGuide", false);

html_source->AddBoolean(
"showResetProfileBannerV2",
@@ -510,7 +510,7 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
base::FeatureList::IsEnabled(privacy_sandbox::kRelatedWebsiteSetsUi));
html_source->AddBoolean("isPrivacySandboxAdPrivacyUxDeprecationEnabled",
Expand Down
24 changes: 24 additions & 0 deletions patches/ui_patches/hide-useless-prefs.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,30 @@ Unless required by applicable law or agreed to in writing, software distributed
distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and limitations under the License.
---
diff --git a/chrome/browser/resources/settings/site_settings/v8_page.html b/chrome/browser/resources/settings/site_settings/v8_page.html
index 3e6101bb07..50a7b6ec05 100644
--- a/chrome/browser/resources/settings/site_settings/v8_page.html
+++ b/chrome/browser/resources/settings/site_settings/v8_page.html
@@ -25,19 +25,6 @@
sub-label="$i18n{siteSettingsJavascriptOptimizerAllowedSubLabel}"
no-collapse>
</settings-collapse-radio-button>
- <template is="dom-if"
- if="[[enableBlockV8OptimizerOnUnfamiliarSites_]]">
- <settings-collapse-radio-button
- id="blockForUnfamiliarSites"
- class="two-line"
- name="[[javascriptOptimizerSettingEnum_.BLOCKED_FOR_UNFAMILIAR_SITES]]"
- pref="[[prefs.generated.javascript_optimizer]]"
- label="$i18n{siteSettingsJavascriptOptimizerBlockedUnfamiliarSites}"
- sub-label="[[getBlockForUnfamiliarSitesSubLabel_(
- prefs.generated.javascript_optimizer.value)]]"
- no-collapse>
- </settings-collapse-radio-button>
- </template>
<settings-collapse-radio-button
id="blockForAllSites"
class="two-line"
diff --git a/chrome/browser/resources/settings/a11y_page/live_translate.html b/chrome/browser/resources/settings/a11y_page/live_translate.html
index 3fce5bc069..c8ce8d033c 100644
--- a/chrome/browser/resources/settings/a11y_page/live_translate.html
Expand Down