Skip to content

Commit bcc62bd

Browse files
committed
fix(pencil): Fix bug config updates are disabled
1 parent f366649 commit bcc62bd

File tree

4 files changed

+14
-8
lines changed

4 files changed

+14
-8
lines changed

src/agent-manager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ export default class AgentManager {
107107
//start hgeart beats
108108
this.heartBeatManager = new HeartBeatManager(this.options.heartBeatInterval, this.apiManager.heartBeat.bind(this));
109109
this.heartBeatManager.startHeartBeatLoop();
110-
this.configurationUpdate.call(this);
111-
112110
this.eventManager.setSessionId(data.sessionId);
113111
this.eventManager.startEventsPersist();
114112
this.isAgentStarted = true;
115-
113+
114+
//schedual config update
115+
this.configurationUpdate.call(this);
116116
Logger.debug('Agent successfuly started!');
117117
return resolve(true);
118118
} else {

src/events/sdk-event.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ export default class SDKEvent implements IEvent {
3434
Logger.debug('Building SDK event');
3535
// extract info from session
3636
const { req } = SessionManager.getLastSession();
37+
if (!req) {
38+
Logger.debug('request is empty', req);
39+
}
3740
const reqCtx = mergeRequestContexts(event.context || {}, contextFromRequest(req));
3841

3942
const decryptedToken = decrypt(reqCtx?.clientToken, options.apiKey);
@@ -42,7 +45,6 @@ export default class SDKEvent implements IEvent {
4245
Logger.debug('Parsed client token:', parsedToken);
4346

4447
const user: any = event.userTraits || {};
45-
4648
this.rid = v4();
4749
this.eventType = event.event;
4850
this.userId = event.userId || '';

src/interceptors/http-server-interceptor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export default class HttpServerInterceptor extends Interceptor implements IInter
7474
if (this && this.sn_finished) {
7575
return;
7676
}
77-
if (arguments.length > 0 && arguments[0] !== undefined) {
77+
if (arguments && arguments.length > 0 && arguments[0] !== undefined) {
7878
intercept(this.req && this.req.sn_uid, 'write');
7979
}
8080
return original.apply(this, arguments);
@@ -105,7 +105,7 @@ export default class HttpServerInterceptor extends Interceptor implements IInter
105105
intercept(this.req && this.req.sn_uid, 'end');
106106
const { req, res } = SessionManager.getSession(this.req?.sn_uid);
107107
if (req && res) {
108-
risk({ eventType: EventType.RISK, context: { req: contextFromRequest(req), res: contextFromResponse(res) } });
108+
risk({ event: EventType.RISK, context: { req: contextFromRequest(req), res: contextFromResponse(res) } });
109109
}
110110

111111
SessionManager.cleanSession(this.req && this.req.sn_uid);

src/session-manager.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { IncomingMessage, ServerResponse } from 'http';
2-
2+
import { Logger } from './logger';
33
export interface Session {
44
req: IncomingMessage | any;
55
res: ServerResponse | any;
@@ -10,14 +10,17 @@ export default class SessionManager {
1010
private static session: Map<string, Session> = new Map<string, Session>();
1111

1212
static getLastSession(): Session {
13-
return SessionManager.session.get(SessionManager.lastSessionId) || { req: null, res: null };
13+
const session = SessionManager.session.get(SessionManager.lastSessionId) || { req: null, res: null };
14+
Logger.debug(`[SessionManager] Getting last session by: ${SessionManager.lastSessionId}, is: ${session.req?.sn_uid}`);
15+
return session;
1416
}
1517

1618
static getSession(id: string): Session {
1719
return SessionManager.session.get(id) || { req: null, res: null };
1820
}
1921

2022
static setSession(id: string, session: Session) {
23+
Logger.debug(`[SessionManager] Setting session: ${id}`);
2124
session.req.sn_uid = id;
2225
session.res.sn_uid = id;
2326
SessionManager.session.set(id, session);
@@ -27,6 +30,7 @@ export default class SessionManager {
2730
}
2831

2932
static cleanSession(id: string) {
33+
Logger.debug(`[SessionManager] Cleaning session: ${id}`);
3034
SessionManager.session.delete(id);
3135
}
3236
}

0 commit comments

Comments
 (0)