Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Restore MiniInternetTestCase #281

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

lschulz
Copy link
Contributor

@lschulz lschulz commented Mar 11, 2025

Add MiniInternetTestCase, IPAnyCastTestCase, and HostMgmtTestCase test cases to the CI pipeline.

Replaces the real world AS ping test in MiniInternetTestCase with an HTTP GET test that can get through the firewall of a GitHub action runner.

Add MiniInternetTestCase, IPAnyCastTestCase, and HostMgmtTestCase
test cases to the CI pipeline.

Replaces the real world AS ping test in MiniInternetTestCase with an
HTTP GET test that can get through the firewall of a GitHub action
runner.
@lschulz
Copy link
Contributor Author

lschulz commented Mar 11, 2025

MiniInternetTestCase fails with

======================================================================
FAIL: test_internet_connection (internet.mini_internet.MiniInternetTestCase.MiniInternetTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/seed-emulator/seed-emulator/tests/internet/mini_internet/MiniInternetTestCase.py", line 25, in test_internet_connection
    self.assertTrue(self.ping_test(self.source_host, ip))
AssertionError: False is not true
----------------------------------------------------------------------

IPAnyCastTestCase and HostMgmtTestCase also fail.

MiniInternetTestCase passes on my machine if a go back to commit 7e71113, so the problem was probably introduced since then.

@amdfxlucas could you take a look?

@kevin-w-du kevin-w-du merged commit 3d66754 into seed-labs:master Mar 13, 2025
2 of 3 checks passed
@amdfxlucas amdfxlucas mentioned this pull request Mar 13, 2025
@lschulz lschulz deleted the ci-tests-pr branch March 13, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants