Skip to content

Multiple APDU filters shall be combined per OR operation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: android-5.0.0_r3-scapi
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2016

According to Secure Element Access Control specification, APDU filters
shall be combined per OR operation if multiple access rules contain the
different filters.

The APDU access is not changed from the initial value "UNDEFINED" if the
previous access rule has APDU filter, so new APDU filter shall be
combined unless the APDU access is already set to "DENIED".

According to Secure Element Access Control specification, APDU filters
shall be combined per OR operation if multiple access rules contain the
different filters.

The APDU access is not changed from the initial value "UNDEFINED" if the
previous access rule has APDU filter, so new APDU filter shall be
combined unless the APDU access is already set to "DENIED".
@ghost
Copy link
Author

ghost commented Jun 13, 2016

The section 3.4.1 of Secure Element Access Control says;

If multiple access rules contain APDU filters, then these shall be combined per OR operation.

Actually putWithMerge() is implemented for that, but the condition is not good.

Please imagine that there are the following 2 access rules detected. Both APDU filters must work in this case.

- Access rule 1 contains an APDU filter A
- Access rule 2 contains an APDU filter B

ApduAccess is still not changed to ChannelAccess.ACCESS.ALLOWED right after processing the access rule 1, so the APDU filter B is not merged mistakenly when processing the access rule 2 in the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants