Feature add batchwise filtered reading #32
+153
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, thank you for the PR and for the effort. Could you please format the code with Black? It's not really mentioned anywhere yet, but I recently formatted the entire code base with it. It looks like there are some formatting changes in the diff. |
Collaborator
|
@smoosbau I integrated the black code check into the pipeline. Can you merge main into your PR? Then it should automatically pick up the check as part of the pipeline. |
|
Hi @lumagi, |
Author
|
@lumagi, formatting is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I needed a possibility to (a) filter the data read from the binary files and (b) read the data batchwise due to the size (my measurements take about 8h (sampling rate 1024Hz)) I added this functionalities.
Filtering is added to the complete BinaryReader class, while batchwise reading is realized using a new subclass.
This Pull Request is currently a draft, as I'm not sure wether the maintainers prefere another realization of that features or discard it completet.
Thus, I'd like to ask @lumagi to review this draft and share his thoughts with me. Afterwards, I can either proceed with documentation and tests, change the design / implementation, or delete this PR.
Any feedback is appreciated. :)