Document implementation of Myers algorithm#21
Merged
ddssff merged 5 commits intoseereason:masterfrom Apr 22, 2026
Merged
Conversation
Bodigrim
reviewed
Apr 16, 2026
Collaborator
Bodigrim
left a comment
Bodigrim
left a comment
There was a problem hiding this comment.
Thanks, I gave it a quick proof read.
ninioArtillero
force-pushed
the
ninioArtillero/docs
branch
from
1ab7ac4 to
d05df2e
Compare
Bodigrim
reviewed
Apr 17, 2026
ninioArtillero
force-pushed
the
ninioArtillero/docs
branch
from
d05df2e to
19a9566
Compare
ninioArtillero
commented
Apr 17, 2026
| -- diff. Note that there is an @lcs@ function in the | ||
| -- 'Data.Algorithm.Diff' module, but it's not exported. It's trivial | ||
| -- to reconstruct the LCS though, just by taking the 'B' elements. | ||
| -- | Obtains a longest common subsequence of two lists using their diff. |
Contributor
Author
There was a problem hiding this comment.
Removed because the LCS is actually being materialized here.
Bodigrim
approved these changes
Apr 17, 2026
Member
|
Which is the best merge option, merge, rebase, or squash? |
Collaborator
|
I'd squash perhaps. |
Member
|
It didn't ask me this time. |
Contributor
Author
|
Thanks for the prompt review and merge! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation haddocks to the
Diffmodule internal functions with the goal of making the implementation transparent. For this, its connection to the original Myers paper formulation and concepts are stablished.