test: add scanner update rate override for testing #3241
+69
−36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,29 @@ | ||||||||||||||||||||||||||||||||||||||||
| import { mock } from 'node:test'; | ||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||
| export async function runWithMockTimers<T>( | ||||||||||||||||||||||||||||||||||||||||
| runPromise: Promise<T>, | ||||||||||||||||||||||||||||||||||||||||
| tickMs = 4000 | ||||||||||||||||||||||||||||||||||||||||
| ): Promise<T> { | ||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+3
to
+6
Member
There was a problem hiding this comment. Takes an already-invoked Promise instead of a factory. Its fine as it is for now since |
||||||||||||||||||||||||||||||||||||||||
| mock.timers.enable({ apis: ['setTimeout'] }); | ||||||||||||||||||||||||||||||||||||||||
| try { | ||||||||||||||||||||||||||||||||||||||||
| let settled = false; | ||||||||||||||||||||||||||||||||||||||||
| runPromise | ||||||||||||||||||||||||||||||||||||||||
| .catch(() => undefined) | ||||||||||||||||||||||||||||||||||||||||
| .finally(() => { | ||||||||||||||||||||||||||||||||||||||||
| settled = true; | ||||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||||
| const maxTicks = 100000; | ||||||||||||||||||||||||||||||||||||||||
| for (let i = 0; i < maxTicks && !settled; i++) { | ||||||||||||||||||||||||||||||||||||||||
| await new Promise((resolve) => setImmediate(resolve)); | ||||||||||||||||||||||||||||||||||||||||
| mock.timers.tick(tickMs); | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
| if (!settled) { | ||||||||||||||||||||||||||||||||||||||||
| throw new Error( | ||||||||||||||||||||||||||||||||||||||||
| `runWithMockTimers: promise did not settle after ${maxTicks} ticks` | ||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+16
to
+24
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- file ---'
cat -n server/test/runWithMockTimers.ts
printf '%s\n' '--- references ---'
rg -n --glob '!node_modules' 'runWithMockTimers|mock\.timers\.tick|setImmediate' server package.jsonRepository: seerr-team/seerr Length of output: 5464 🏁 Script executed: #!/bin/bash
set -eu
node --input-type=commonjs <<'JS'
const { mock } = require('node:test');
async function probe(runPromise, maxTicks = 3, tickMs = 1) {
mock.timers.enable({ apis: ['setTimeout'] });
try {
let settled = false;
runPromise
.catch(() => undefined)
.finally(() => {
settled = true;
});
for (let i = 0; i < maxTicks && !settled; i++) {
await new Promise((resolve) => setImmediate(resolve));
mock.timers.tick(tickMs);
if (i === maxTicks - 1) {
console.log('immediately after final tick:', settled);
}
}
console.log('guard sees settled:', settled);
return settled;
} finally {
mock.timers.reset();
}
}
let release;
const runPromise = new Promise((resolve) => {
release = resolve;
});
setTimeout(() => release('done'), 3);
probe(runPromise).then(() => {
setImmediate(() => console.log('after one additional setImmediate:', true));
});
JSRepository: seerr-team/seerr Length of output: 256 Flush promise callbacks before applying the guard. If the final 🤖 Prompt for AI Agents
Member
There was a problem hiding this comment. @michaelhthomas can you add one more flush before the check?
Comment on lines
+16
to
+24
Member
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||
| return await runPromise; | ||||||||||||||||||||||||||||||||||||||||
| } finally { | ||||||||||||||||||||||||||||||||||||||||
| mock.timers.reset(); | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonarr was being imported before the
getTvShowmock which caused it to not work. Moved it here so the mock actually applies.